-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throttle ADR #682
Throttle ADR #682
Conversation
@ivan-gavran I've incorporated my understanding of your invariant derivation into this PR, hopefully the |
Cool! It is indeed much clearer now. I noticed a few things that could still be improved and created a PR since I don't have access to push directly. Ping me if you want to discuss the changes. One question occurred to me: why not using Latex rendering that Github supports now for ADRs? Finally, a bit of nitpicking: why calling the property you are describing an invariant? An invariant would be something that holds always (e.g., a simple one, it is always the case that the meter's value is smaller than its allowance), whereas what you are describing here is a property. |
Thanks for the feedback! On latex rendering, I wasn't aware of this, I'll take a look 👍 On property vs invariant, I agree with your suggestion and have changed instances of "invariant" to "property" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Removes
throttle.md
in favor of a more complete ADR for throttlingLinked issues
Closes: #615
See cosmos/ibc#924 for changes to spec needed for throttling
Type of change
Docs
: Adds documentation