Update to Latest SDK #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently failing because of the changes to IBC routing. I've tried to incorporate them over in Gaia, but I'm not able to get channel handshakes working. Try running the following command when building from ./two-chainz local skip && ./config-relayer skip && rly tx link demo -o 3s -dThis commit has the simapp changes that I ported over: |
11 tasks
jackzampolin
changed the title
AdityaSripal
reviewed
Apr 9, 2020
| @@ -109,7 +109,7 @@ func (src *PathEnd) ChanInit(dst *PathEnd, ordering chanState.Order, signer sdk. | |||
| return chanTypes.NewMsgChannelOpenInit( | |||
| src.PortID, | |||
| src.ChannelID, | |||
| defaultIBCVersion, | |||
| defaultTransferVersion, | |||
There was a problem hiding this comment.
Note, a future PR should refactor this so that relayer doesn't just support transfer channels. We can do this by making the channel version a part of PathEnd, or something similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.