Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename VmToolBar to ToolBar #1277

Closed
okwme opened this issue Sep 4, 2018 · 2 comments · Fixed by #1745
Closed

rename VmToolBar to ToolBar #1277

okwme opened this issue Sep 4, 2018 · 2 comments · Fixed by #1745
Labels
good first issue 🙌 low priority has been discussed, will be addressed later refactor

Comments

@okwme
Copy link
Contributor

okwme commented Sep 4, 2018

as discussed in this PR
#1188
@okwme okwme added the low priority has been discussed, will be addressed later label Sep 4, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Sep 4, 2018

Should this be labelled discuss to go through our process?

@faboweb
Copy link
Collaborator

faboweb commented Sep 5, 2018

According to process it should. I don't know if necessary though

@faboweb faboweb removed the discuss label Sep 18, 2018
@jbibla jbibla changed the title change VmToolBar to ToolBar rename VmToolBar to ToolBar Dec 10, 2018
@coreycosman coreycosman mentioned this issue Dec 13, 2018
Merged
2 tasks
This was referenced Jan 16, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 14, 2019
Closed
Merged
@faboweb faboweb mentioned this issue Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 🙌 low priority has been discussed, will be addressed later refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Coreycosman/1277 rename-VmToolBar-to-ToolBar coreycosman/voyager
4 participants
@okwme @NodeGuy @faboweb @jbibla