Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coreycosman/1277 rename-VmToolBar-to-ToolBar #1745

Conversation

coreycosman
Copy link
Contributor

Closes #ISSUE

Description:

Renamed VmToolBar files to ToolBar, updated all import statements, template components, snapshots

closes #1277

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #1745 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           develop   #1745   +/-   ##
=======================================
  Coverage     97.7%   97.7%           
=======================================
  Files          102     102           
  Lines         2096    2096           
  Branches        93      93           
=======================================
  Hits          2048    2048           
  Misses          39      39           
  Partials         9       9
Impacted Files Coverage Δ
app/src/renderer/components/common/ToolBar.vue 100% <ø> (ø)
...src/renderer/components/common/PagePreferences.vue 100% <100%> (ø) ⬆️
...pp/src/renderer/components/staking/PageStaking.vue 100% <100%> (ø) ⬆️
.../renderer/components/governance/TableProposals.vue 100% <100%> (ø) ⬆️
.../renderer/components/governance/PageGovernance.vue 100% <100%> (ø) ⬆️
app/src/renderer/components/wallet/PageSend.vue 100% <100%> (ø) ⬆️
...rc/renderer/components/wallet/PageTransactions.vue 97.29% <100%> (ø) ⬆️
...rc/renderer/components/staking/TableValidators.vue 100% <100%> (ø) ⬆️
app/src/renderer/components/wallet/PageWallet.vue 91.66% <100%> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #1745 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           develop   #1745   +/-   ##
=======================================
  Coverage     97.7%   97.7%           
=======================================
  Files          102     102           
  Lines         2096    2096           
  Branches        93      93           
=======================================
  Hits          2048    2048           
  Misses          39      39           
  Partials         9       9
Impacted Files Coverage Δ
app/src/renderer/components/common/ToolBar.vue 100% <ø> (ø)
...src/renderer/components/common/PagePreferences.vue 100% <100%> (ø) ⬆️
...pp/src/renderer/components/staking/PageStaking.vue 100% <100%> (ø) ⬆️
.../renderer/components/governance/TableProposals.vue 100% <100%> (ø) ⬆️
.../renderer/components/governance/PageGovernance.vue 100% <100%> (ø) ⬆️
app/src/renderer/components/wallet/PageSend.vue 100% <100%> (ø) ⬆️
...rc/renderer/components/wallet/PageTransactions.vue 97.29% <100%> (ø) ⬆️
...rc/renderer/components/staking/TableValidators.vue 100% <100%> (ø) ⬆️
app/src/renderer/components/wallet/PageWallet.vue 91.66% <100%> (ø) ⬆️

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to go 👍 thanks for the contribution

@jbibla jbibla merged commit 422543d into luniehq:develop Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename VmToolBar to ToolBar
3 participants