Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Results msg on no validators #1818

Closed
fedekunze opened this issue Jan 11, 2019 · 4 comments · Fixed by #1861
Closed

No Results msg on no validators #1818

fedekunze opened this issue Jan 11, 2019 · 4 comments · Fixed by #1861
Assignees
@faboweb
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed high priority ❗ ux-improvement issues that would improve the user experience

Comments

@fedekunze
Copy link
Contributor

Description:

When there are no validators, or the response hasn't been received (in my case because of Unchecked runtime.lastError: The message port closed before a response was received.), the Validators tab shows a No Results message. It should display a message that there are no validators on the network.

screen shot 2019-01-11 at 11 39 03 am
@fedekunze fedekunze added ux-improvement issues that would improve the user experience high priority ❗ labels Jan 11, 2019
@faboweb
Copy link
Collaborator

faboweb commented Jan 11, 2019

It should show a message that the validators haven' been loaded yet in my opinion.

@faboweb faboweb added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Jan 15, 2019
@faboweb faboweb self-assigned this Jan 15, 2019
@faboweb
Copy link
Collaborator

faboweb commented Jan 22, 2019

@fedekunze sorry was asking so late but is there a way to reproduce this?
@sabau in theory this should be handled by your TmPage Pr, isn't it?

@fedekunze
Copy link
Contributor Author

fedekunze commented Jan 22, 2019 •
edited
Loading

hmmm I don't remember how to reproduce it (not loading validators yet). But this issue was more about the message being displayed more than the not loaded validators

@faboweb
Copy link
Collaborator

faboweb commented Jan 22, 2019

Got it tested. 👍 But thank you. :)

@faboweb faboweb mentioned this issue Jan 22, 2019
Merged
2 tasks
This was referenced Feb 14, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faboweb faboweb

Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed high priority ❗ ux-improvement issues that would improve the user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fabo/1818 fix validators message luniehq/lunie
2 participants
@faboweb @fedekunze