Fabo/1818 fix validators message #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1861 +/- ##
===========================================
- Coverage 95.08% 95.08% -0.01%
===========================================
Files 124 124
Lines 2910 2909 -1
Branches 121 121
===========================================
- Hits 2767 2766 -1
Misses 135 135
Partials 8 8
|
|
can you attach a snapshot on the description or add a testcase w/Snapshot when the validators are empty ? |
fedekunze
approved these changes
Jan 23, 2019
not true! ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1818
Description:
On error the module would set
loadingto false. But on errorloadingshould staytrueto indicate the pending loading.❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer