Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PR template #1948

Merged
merged 7 commits into from
Feb 13, 2019
Merged

update PR template #1948

merged 7 commits into from
Feb 13, 2019

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Feb 11, 2019

Closes #1905
Closes #1904

Description:

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer


<!-- Briefly describe what you're adding or fixing with this PR -->

❤️ Thank you!
Thank you! 🚀
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XD why?????

PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #1948 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1948   +/-   ##
=======================================
  Coverage     95.1%   95.1%           
=======================================
  Files          120     120           
  Lines         2593    2593           
  Branches       122     122           
=======================================
  Hits          2466    2466           
  Misses         117     117           
  Partials        10      10

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #1948 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1948   +/-   ##
========================================
  Coverage    95.18%   95.18%           
========================================
  Files          121      121           
  Lines         2618     2618           
  Branches       122      122           
========================================
  Hits          2492     2492           
  Misses         116      116           
  Partials        10       10

faboweb
faboweb previously approved these changes Feb 12, 2019
@faboweb faboweb merged commit b6e9332 into develop Feb 13, 2019
@faboweb faboweb deleted the fedekunze/update-PR-template branch February 13, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants