-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update PR template #1948
Merged
Merged
update PR template #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faboweb
reviewed
Feb 11, 2019
|
||
<!-- Briefly describe what you're adding or fixing with this PR --> | ||
|
||
❤️ Thank you! | ||
Thank you! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XD why?????
faboweb
reviewed
Feb 11, 2019
jbibla
reviewed
Feb 11, 2019
Co-Authored-By: fedekunze <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #1948 +/- ##
=======================================
Coverage 95.1% 95.1%
=======================================
Files 120 120
Lines 2593 2593
Branches 122 122
=======================================
Hits 2466 2466
Misses 117 117
Partials 10 10 |
Codecov Report
@@ Coverage Diff @@
## develop #1948 +/- ##
========================================
Coverage 95.18% 95.18%
========================================
Files 121 121
Lines 2618 2618
Branches 122 122
========================================
Hits 2492 2492
Misses 116 116
Partials 10 10 |
faboweb
previously approved these changes
Feb 12, 2019
…kunze/update-PR-template pull develop
…mos/voyager into fedekunze/update-PR-template merge
faboweb
approved these changes
Feb 13, 2019
This was referenced Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1905
Closes #1904
Description:
❤️ Thank you!
CHANGELOG.md
with issue # and GitHub usernameFiles changed
in the github PR explorer