Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PR template #1948

Merged
merged 7 commits into from
Feb 13, 2019
Merged

update PR template #1948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2df4b20
update PR template
Feb 11, 2019
2380a56
Update PULL_REQUEST_TEMPLATE.md
faboweb Feb 11, 2019
baaf864
Update PULL_REQUEST_TEMPLATE.md
fedekunze Feb 11, 2019
ea5ddd6
Update PULL_REQUEST_TEMPLATE.md
fedekunze Feb 11, 2019
461203b
Merge branch 'develop' of https://github.com/cosmos/voyager into fede…
Feb 12, 2019
06ec48c
changelog
Feb 12, 2019
13ef2d8
Merge branch 'fedekunze/update-PR-template' of https://github.com/cos…
Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- [\#1221](https://github.com/cosmos/voyager/issues/1221) individual linter check on GitHub @faboweb
- [\#1855](https://github.com/cosmos/voyager/issues/1855) skip gaia build if already built that hash @sabau
- [\#1922](https://github.com/cosmos/voyager/issues/1922) removed font awesome @jbibla
- [\#1948](https://github.com/cosmos/voyager/pull/1948) changed PR template @fedekunze

### Fixed

Expand Down
15 changes: 9 additions & 6 deletions PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,20 @@
Closes #ISSUE

_Description:_
**Description:**

<!-- Briefly describe what you're adding or fixing with this PR -->

❤️ Thank you!
Thank you! 🚀
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XD why?????


---

<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
v Thanks for creating a PR!
v Before smashing the submit button please review the checkboxes
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->
For contributor:

- [ ] Added entries in `CHANGELOG.md` with issue # and GitHub username
- [ ] Reviewed `Files changed` in the github PR explorer
- [ ] Attach screenshots of the UI components on the PR description (if applicable)
- [ ] Scope of work approved for big PRs

For reviewer:

- [ ] Manually tested the changes on the UI