Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace polyfill.io for cdnjs hosted link #1598

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 7, 2024

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactoring and improving code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Description

jekyll-theme-chirpy loads polyfill from polyfill.io for MathJax. The PR replaces polyfill.io w/ cdnjs.cloudflare.com/polyfill.

Additional context

polyfill.io was acquired by a China-based CDN company "Funnull", see the announcement from the polyfill.io domain owner's Twitter and https://github.com/polyfillpolyfill/polyfill-service/issues/2834. Despite Funnull's claims of operating in the United States, the predominance of Simplified Chinese on its website suggests otherwise, and it turns out that "Funnull" is notorious for providing service for the betting and pornography industries.

The original creator of the polyfill.io has voiced his concern on Twitter. And since the acquisition, numerous issues have emerged (polyfillpolyfill/polyfill-service#2835, polyfillpolyfill/polyfill-service#2838, AlistGo/alist#6100), rendering the polyfill.io service extremely unstable. Since then, Fastly (Announcement) and Cloudflare (Announcement) has hosted their own instances of polyfill.io service.

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@cotes2020 cotes2020 changed the base branch from master to release/6.5.3 March 7, 2024 19:47
@cotes2020 cotes2020 force-pushed the replace-polyfill-io branch from 91f8c35 to d3df61a Compare March 7, 2024 19:51
@cotes2020 cotes2020 changed the title refactor: replace polyfill.io refactor: replace polyfill.io for cdnjs hosted link Mar 7, 2024
@cotes2020 cotes2020 merged commit 75a3d73 into cotes2020:release/6.5.3 Mar 7, 2024
4 of 5 checks passed
Vinfall added a commit to Vinfall/Rath that referenced this pull request Mar 20, 2024
Vinfall added a commit to Vinfall/Rath that referenced this pull request Apr 2, 2024
kimbob13 pushed a commit to kimbob13/kimbob13.github.io that referenced this pull request May 25, 2024
Vinfall added a commit to Vinfall/Rath that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants