improvements to and rename of cmake.yaml #1400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this needs to be rebased |
|
@redraincatching can you rebase this PR? |
redraincatching
force-pushed
the
cmake-imp
branch
from
426d9e3 to
e82fc3b
Compare
|
the failing build is for ubuntu 18.04, as it is attempting to perform rather than use that, i would recommend a more thorough solution, as @jonesmz has in the adjust-ubuntu-runners branch. |
|
Can the change applied here be used? #1548 |
|
@jonesmz yes, that's the temporary fix, and will work until github removes node16 support. i can add it to this change if that would be preferred? |
redraincatching
force-pushed
the
cmake-imp
branch
from
e82fc3b to
5506281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseding changes made in pr #1394 on request of @jonesmz
dependent on pr #1399 - uses the composite action for dependency installation i wrote there
cleaned up cmake.yml and renamed in the same manner as the other .yml files