Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query running in the vm sandbox #89

Closed
wants to merge 1 commit into from

Conversation

pofider
Copy link

@pofider pofider commented Nov 22, 2018

The basic query hangs if it is executed through nodejs vm sandbox.
The problem is that the driver uses this code to verify if parameter is callback

if (params instanceof Function) 

This gives false for function in the vm sandbox. See this described here.
The correct way for checking if the parameter is function is this

if (typeof params === 'function') {

I submitted the fix in one place and also test. Unfortunately it hangs when it runs with mocks. I was not able to find out why.

@cb-sdk-robot
Copy link

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Keep in mind that the emails we are seeing on the commits are: hon*******der@sez***.cz

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

@cb-sdk-robot
Copy link

Unfortunately it has been 7 days and we are still unable to confirm that you have signed our CLA. We sincerely appreciate your submission and hope that you will register and resubmit this Pull Request in the future!

::SDKBOT/PR:timeout

@pofider
Copy link
Author

pofider commented Dec 6, 2018

I actually signed your CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants