Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync schema with current couper master branch #135

Closed
malud opened this issue Mar 7, 2024 · 5 comments · Fixed by #136
Closed

sync schema with current couper master branch #135

malud opened this issue Mar 7, 2024 · 5 comments · Fixed by #136

Comments

@malud
Copy link
Collaborator

malud commented Mar 7, 2024

Ensure that we are up-to-date with the recent implementation.
E.g. TLS block or newly added functions.

@johakoch
Copy link
Contributor

Which functions are missing? I searched the couper changelog for added functions. The last added to couper were

  • trim() (in couper 1.11.0, added to vscode in trim() function #112) and then
  • contains(), join(), keys(), length(), lookup(), set_intersection(), to_number() (in couper 1.8.0, added to vscode in new HCL functions #72).

@johakoch
Copy link
Contributor

johakoch commented Apr 1, 2024

The tls blocks have different atributes or nested blocks depending on the parent block:

I don't think there's currently a way in the extension code to describe this.
@afflerbach Do you have an idea?

@afflerbach
Copy link
Collaborator

Different nested blocks should be doable with a solution like the dynamic parents lookup for beta_rate_limit.
For dynamic attribute completion, there's need for some similar function based logic somewhere around here.

@johakoch
Copy link
Contributor

johakoch commented Apr 1, 2024

@malud Can you please allow me to push to this repo?

@johakoch
Copy link
Contributor

johakoch commented Apr 1, 2024

@afflerbach Looks like passing a function to parents also works for attributes :-)

@johakoch johakoch linked a pull request Apr 1, 2024 that will close this issue
malud added a commit that referenced this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants