-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(packaging): fix deb packaging #57
Conversation
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
What was the symptom/problem? (link to a brokey build would be nice) I ain't found of npm patch either tbh. |
@@ -29,7 +33,7 @@ jobs: | |||
run: ${{ matrix.additional-install }} | |||
- name: Create package | |||
working-directory: ./packages/cli | |||
run: npx @oclif/dev-cli pack:${{ matrix.pack-command }} | |||
run: ./node_modules/@oclif/dev-cli/bin/run pack:${{ matrix.pack-command }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you tried sudo this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's not the problem.
Example: https://github.com/coveo/cli/runs/2005635079?check_suite_focus=true
So, following the discussion during the scrum here is the accompanying issue on oclif-dev repo: |
patch === oclif/dev-cli#282 |
Use https://www.npmjs.com/package/patch-package (already used for other dependency in the project) to fix missing
sudo
for deb (linux) packaging with oclif-dev.https://coveord.atlassian.net/browse/CDX-107