Skip to content

Commit

Permalink
feat(atomic): change prop name and update typo
Browse files Browse the repository at this point in the history
  • Loading branch information
jelmedini committed Jul 3, 2023
1 parent 4ee8afb commit 8a5b814
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 17 deletions.
4 changes: 2 additions & 2 deletions packages/atomic/src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ export namespace Components {
/**
* The text tooltip to show on the result action icon
*/
"label"?: string;
"tooltip": string;
}
interface AtomicInsightResultActionBar {
}
Expand Down Expand Up @@ -3533,7 +3533,7 @@ declare namespace LocalJSX {
/**
* The text tooltip to show on the result action icon
*/
"label"?: string;
"tooltip"?: string;
}
interface AtomicInsightResultActionBar {
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {Component, Prop, State, h} from '@stencil/core';
import QuickView from '../../../images/quickview.svg';
import Quickview from '../../../images/quickview.svg';
import {
InitializableComponent,
InitializeBindings,
Expand All @@ -21,20 +21,20 @@ export class AtomicInsightResultAction implements InitializableComponent {
/**
* Specify the result action icon to display.
*/
@Prop() public icon = QuickView;
@Prop({mutable: true}) public icon = Quickview;

/**
* The text tooltip to show on the result action icon
*/
@Prop({reflect: true}) public label?: string;
@Prop({mutable: true}) public tooltip = '';

public render() {
return (
<IconButton
icon={this.icon}
title={this.label}
style="outline-neutral"
partPrefix="result-action"
style="outline-neutral"
icon={this.icon}
title={this.tooltip}
/>
);
}
Expand Down
18 changes: 9 additions & 9 deletions packages/atomic/src/pages/examples/insights.html
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@
}
</style>
<atomic-insight-result-action-bar>
<atomic-insight-result-action title="test"></atomic-insight-result-action>
<atomic-insight-result-action title="test"></atomic-insight-result-action>
<atomic-insight-result-action title="test"></atomic-insight-result-action>
<atomic-insight-result-action tooltip="test"></atomic-insight-result-action>
<atomic-insight-result-action tooltip="test"></atomic-insight-result-action>
<atomic-insight-result-action tooltip="test"></atomic-insight-result-action>
</atomic-insight-result-action-bar>
<atomic-result-section-badges>
<atomic-field-condition must-match-sourcetype="Salesforce">
Expand Down Expand Up @@ -183,9 +183,9 @@
}
</style>
<atomic-insight-result-action-bar>
<atomic-insight-result-action title="test"></atomic-insight-result-action>
<atomic-insight-result-action title="test"></atomic-insight-result-action>
<atomic-insight-result-action title="test"></atomic-insight-result-action>
<atomic-insight-result-action tooltip="test"></atomic-insight-result-action>
<atomic-insight-result-action tooltip="test"></atomic-insight-result-action>
<atomic-insight-result-action tooltip="test"></atomic-insight-result-action>
</atomic-insight-result-action-bar>
<atomic-result-section-badges>
<atomic-field-condition must-match-sourcetype="Salesforce">
Expand Down Expand Up @@ -317,9 +317,9 @@
}
</style>
<atomic-insight-result-action-bar>
<atomic-insight-result-action title="test"></atomic-insight-result-action>
<atomic-insight-result-action title="test"></atomic-insight-result-action>
<atomic-insight-result-action title="test"></atomic-insight-result-action>
<atomic-insight-result-action tooltip="test"></atomic-insight-result-action>
<atomic-insight-result-action tooltip="test"></atomic-insight-result-action>
<atomic-insight-result-action tooltip="test"></atomic-insight-result-action>
</atomic-insight-result-action-bar>
<atomic-result-section-badges>
<atomic-field-condition must-match-sourcetype="Salesforce">
Expand Down

0 comments on commit 8a5b814

Please sign in to comment.