simply not supporting CJS

https://coveord.atlassian.net/browse/KIT-2541
coveo · Sep 10, 2024 · af5cd1e · af5cd1e
1 parent 60684c4
commit af5cd1e
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 17 deletions.
diff --git a/packages/atomic-react/commerce/package.json b/packages/atomic-react/commerce/package.json
@@ -3,7 +3,6 @@
   "name": "commerce",
   "type": "module",
   "description": "Atomic React Commerce Module",
-  "main": "../dist/commerce.index.js",
   "module": "../dist/commerce.index.js",
   "types": "../dist/commerce.index.d.ts",
   "license": "Apache-2.0"

diff --git a/packages/atomic-react/package.json b/packages/atomic-react/package.json
@@ -12,15 +12,13 @@
     "build": "nx build",
     "clean": "rimraf -rf dist",
     "build:bundles:esm": "tsc -p tsconfig.esm.json",
-    "build:bundles:cjs": "tsc -p tsconfig.cjs.json",
     "build:bundles:iife": "rollup --config rollup.config.mjs",
-    "build:bundles": "concurrently \"npm run build:bundles:esm\" \"npm run build:bundles:cjs\"  \"npm run build:bundles:iife\"",
+    "build:bundles": "concurrently \"npm run build:bundles:esm\" \"npm run build:bundles:iife\"",
     "publish:npm": "npm run-script -w=@coveo/release npm-publish",
     "publish:bump": "npm run-script -w=@coveo/release bump",
     "promote:npm:latest": "node ../../scripts/deploy/update-npm-tag.mjs latest",
     "build:assets": "ncp ../atomic/dist/atomic/assets dist/assets && ncp ../atomic/dist/atomic/lang dist/lang "
   },
-  "main": "./dist/cjs/index.js",
   "module": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "files": [

diff --git a/packages/atomic-react/recommendation/package.json b/packages/atomic-react/recommendation/package.json
@@ -2,7 +2,6 @@
   "private": true,
   "name": "recommendation",
   "description": "Atomic React Recommendation Module",
-  "main": "../dist/cjs/recommendation.index.js",
   "module": "../dist/recommendation.index.esm.js",
   "types": "../dist/recommendation.index.d.ts",
   "license": "Apache-2.0"

diff --git a/packages/atomic-react/tsconfig.cjs.json b/packages/atomic-react/tsconfig.cjs.json
diff --git a/packages/samples/atomic-react/project.json b/packages/samples/atomic-react/project.json
@@ -9,7 +9,7 @@
       "outputs": ["{projectRoot}/public/dist"],
       "executor": "nx:run-commands",
       "options": {
-        "commands": [],
+        "commands": ["tsc --noEmit", "tsc --module es2022 --noEmit"],
         "parallel": true,
         "cwd": "packages/samples/atomic-react"
       }

diff --git a/packages/samples/atomic-react/tsconfig.json b/packages/samples/atomic-react/tsconfig.json
@@ -2,10 +2,10 @@
   "extends": "../../../tsconfig.json",
   "compilerOptions": {
     "target": "es2016",
-    "module": "ES6",
     "esModuleInterop": true,
-    "lib": ["DOM"],
-    "moduleResolution": "node",
+    "lib": ["DOM", "ES2022"],
+    "moduleResolution": "Bundler",
+    "module": "ES2022",
     "outDir": "./public/dist",
     "types": ["cypress"],
     "jsx": "react"