-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(atomic): add functionality arrow button scroll #2130
Conversation
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
I'll look this up, but before please make sure you have everything merged up and no conflicts with your previous changes 🙏 |
I'll make sure to properly merge when KIT-1722-Segmented-Scrollable is merged to master |
It should always be properly merged when asking for reviewers to look at it otherwise it's hard for us to keep track of what's happening If you want: You can just point this PR to the |
sounds like a good solution to me |
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...c/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.pcss
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/facets/atomic-segmented-facet/atomic-segmented-facet.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/search/facets/atomic-segmented-facet/atomic-segmented-facet.tsx
Outdated
Show resolved
Hide resolved
…crollable/atomic-segmented-facet-scrollable.tsx Co-authored-by: jpmarceau <[email protected]>
…crollable/atomic-segmented-facet-scrollable.tsx Co-authored-by: jpmarceau <[email protected]>
…facet/atomic-segmented-facet.tsx Co-authored-by: jpmarceau <[email protected]>
…crollable/atomic-segmented-facet-scrollable.tsx Co-authored-by: jpmarceau <[email protected]>
…crollable/atomic-segmented-facet-scrollable.tsx Co-authored-by: jpmarceau <[email protected]>
…crollable/atomic-segmented-facet-scrollable.tsx Co-authored-by: jpmarceau <[email protected]>
…crollable/atomic-segmented-facet-scrollable.tsx Co-authored-by: jpmarceau <[email protected]>
…crollable/atomic-segmented-facet-scrollable.tsx Co-authored-by: jpmarceau <[email protected]>
packages/atomic/src/components/search/facets/atomic-segmented-facet/atomic-segmented-facet.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Demo:
https://user-images.githubusercontent.com/97299176/175075314-c8618633-4087-45cd-8536-3ec907dc0514.mov