Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atomic): add segmented scrollable component basic structure #2100

Merged
merged 11 commits into from
Jun 21, 2022

Conversation

mbenkirane-coveo
Copy link
Contributor

@mbenkirane-coveo mbenkirane-coveo commented Jun 15, 2022

Update:

Screen Shot 2022-06-17 at 1 00 40 PM

Prev PR draft issues:
Trying to get the nested elements from the shadow dom returned undefined, so I tried to get the nested elements using the regular dom. I was able to get the elements using the tag name, then mapping them on the atomic-segmented-facet components. Styling wasn't applied properly, more specifically, the "overflow-x-scroll" doesn't work. I also need to remove the mapped duplicated components.

Been looking at this StackOverflow link, but didn't work for me.

Blockers:

  • Child nodes in shadow dom returns undefined
  • When using regular dom, styling not applied to mapped components
  • Need to remove duplicated children as the removeChild() doesn't seem to work

@github-actions
Copy link

Thanks for your contribution @mbenkirane-coveo !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link

github-actions bot commented Jun 15, 2022

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 201.4 201.4 0
search 293.1 293.1 0
insight 221.6 221.6 0
product-listing 214.1 214.1 0
product-recommendation 197.7 197.7 0
recommendation 196.4 196.4 0

@ThibodeauJF ThibodeauJF marked this pull request as draft June 15, 2022 17:19
@ThibodeauJF ThibodeauJF changed the title (Draft) Kit 1722 segmented scrollable feat(atomic): add segmented scrollable component Jun 15, 2022
@mbenkirane-coveo mbenkirane-coveo marked this pull request as ready for review June 17, 2022 16:59
@mbenkirane-coveo mbenkirane-coveo changed the title feat(atomic): add segmented scrollable component feat(atomic): add segmented scrollable component basic structure Jun 17, 2022
@mbenkirane-coveo mbenkirane-coveo marked this pull request as draft June 17, 2022 17:08
@mbenkirane-coveo mbenkirane-coveo marked this pull request as ready for review June 21, 2022 14:55
@ThibodeauJF ThibodeauJF requested a review from liviarett June 21, 2022 15:31
Copy link
Contributor

@ThibodeauJF ThibodeauJF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mbenkirane-coveo mbenkirane-coveo merged commit 7bb2d1c into master Jun 21, 2022
@mbenkirane-coveo mbenkirane-coveo deleted the KIT-1722-Segmented-Scrollable branch June 21, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants