-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(atomic): add segmented scrollable component basic structure #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution @mbenkirane-coveo !
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
ThibodeauJF
reviewed
Jun 15, 2022
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
ThibodeauJF
reviewed
Jun 15, 2022
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
ThibodeauJF
reviewed
Jun 15, 2022
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
ThibodeauJF
reviewed
Jun 15, 2022
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Show resolved
Hide resolved
ThibodeauJF
reviewed
Jun 15, 2022
ThibodeauJF
reviewed
Jun 15, 2022
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
ThibodeauJF
reviewed
Jun 15, 2022
packages/atomic/src/components/facets/atomic-segmented-facet/atomic-segmented-facet.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
ThibodeauJF
reviewed
Jun 17, 2022
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Outdated
Show resolved
Hide resolved
ThibodeauJF
reviewed
Jun 21, 2022
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Show resolved
Hide resolved
ThibodeauJF
reviewed
Jun 21, 2022
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Show resolved
Hide resolved
ThibodeauJF
reviewed
Jun 21, 2022
...rc/components/facets/atomic-segmented-facet-scrollable/atomic-segmented-facet-scrollable.tsx
Show resolved
Hide resolved
ThibodeauJF
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
Prev PR draft issues:
Trying to get the nested elements from the shadow dom returned undefined, so I tried to get the nested elements using the regular dom. I was able to get the elements using the tag name, then mapping them on the atomic-segmented-facet components. Styling wasn't applied properly, more specifically, the "overflow-x-scroll" doesn't work. I also need to remove the mapped duplicated components.
Been looking at this StackOverflow link, but didn't work for me.
Blockers: