Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic): made facet values focus when pressing show more/show less #2043

Merged
merged 7 commits into from
Jun 6, 2022

Conversation

btaillon-coveo
Copy link
Contributor

@btaillon-coveo btaillon-coveo commented May 31, 2022

https://coveord.atlassian.net/browse/KIT-1680

Ideally, when we press "show more", I think the first new value should be selected. However, in some (few) cases, values are sorted and therefor the new and old values are mixed together, which could make this behaviour weird and unintuitive.

@github-actions
Copy link

Thanks for your contribution @btaillon !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@btaillon-coveo btaillon-coveo marked this pull request as ready for review May 31, 2022 16:48
@btaillon-coveo btaillon-coveo requested review from a team and mbenkirane-coveo as code owners May 31, 2022 16:48
@github-actions
Copy link

github-actions bot commented May 31, 2022

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 200.3 200.3 0
search 291.7 291.7 0
insight 189.1 189.1 0
product-listing 213.3 213.3 0
product-recommendation 196.6 196.6 0
recommendation 195.3 195.3 0

@btaillon-coveo btaillon-coveo requested review from a team as code owners June 3, 2022 13:20
@btaillon-coveo btaillon-coveo merged commit 1e77f3e into master Jun 6, 2022
@btaillon-coveo btaillon-coveo deleted the KIT-1680 branch June 6, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants