fix: commit package-lock files right when bumping, undo last bump & fix region #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @ThibodeauJF !
|
ThibodeauJF
commented
Jun 9, 2022
| @@ -3,7 +3,7 @@ | |||
| "team_name": "searchui", | |||
| "general": { | |||
| "aws_regions": { | |||
| "sequential": ["us-east-1"] | |||
| "sequential": ["FIRST_MAIN_REGION"] | |||
There was a problem hiding this comment.
liviarett
reviewed
Jun 10, 2022
ThibodeauJF
changed the title
liviarett
approved these changes
Jun 10, 2022
btaillon-coveo
approved these changes
Jun 10, 2022
mmitiche
approved these changes
Jun 10, 2022
lbergeron
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR but without the cypress changes which are not 100% necessary with the new "commit lockfiles when bumping" #2069
You can disregard the PR bundle size robot cause it can't install wtv on master