Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(headless): update recent queries only when query has results #2110

Merged
merged 3 commits into from
Jun 21, 2022
Merged

fix(headless): update recent queries only when query has results #2110

merged 3 commits into from
Jun 21, 2022

Conversation

liviarett
Copy link
Contributor

@liviarett liviarett requested review from a team and mbenkirane-coveo as code owners June 16, 2022 16:13
@github-actions
Copy link

Thanks for your contribution @liviarett !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 201.4 201.5 0
search 293.5 293.5 0
insight 221.7 221.8 0
product-listing 214.3 214.3 0
product-recommendation 197.7 197.7 0
recommendation 196.4 196.5 0

@ThibodeauJF
Copy link
Contributor

nitpick -> fix(headless) for pr name IMO because this was buggy

@liviarett liviarett changed the title feat(atomic): update recent queries only when query has results fix(headless): update recent queries only when query has results Jun 17, 2022
@liviarett liviarett requested a review from a team as a code owner June 20, 2022 21:36
nathanlb
nathanlb approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@nathanlb nathanlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@liviarett liviarett merged commit 623674b into master Jun 21, 2022
@liviarett liviarett deleted the KIT-1751-update-recent-queries-only-when-there-are-results branch June 21, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamothe olamothe olamothe approved these changes

@ThibodeauJF ThibodeauJF ThibodeauJF approved these changes

@nathanlb nathanlb nathanlb approved these changes

@btaillon-coveo btaillon-coveo btaillon-coveo approved these changes

@mbenkirane-coveo mbenkirane-coveo Awaiting requested review from mbenkirane-coveo

@mmitiche mmitiche Awaiting requested review from mmitiche

@lbergeron lbergeron Awaiting requested review from lbergeron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liviarett @ThibodeauJF @olamothe @nathanlb @btaillon-coveo