embrace CSS #3019
embrace CSS #3019
Conversation
louis-bompart
force-pushed
the
SVCC-2942-css-powa
branch
from
1906db2 to
e30cda1
Compare
|
Pull Request Report PR Title ❌ Title should follow the conventional commit spec: (optional scope): Example: feat(headless): add result-list controller Bundle Size
|
| @@ -123,40 +123,6 @@ export class AtomicInsightResult { | |||
| .join(''); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is a good refacto 🙏 , magic ✨
but one only thing, deleting this selectors make the css global and not only when we have result actions implemented and on hover. for example the hover on each result changes color all the time even if we have no result action to show. I personnaly don't find it disturbing to be global, what do you think ?
case on hover with no result action:
There was a problem hiding this comment.
Good catch, missed it.
Yeah, I think having global is fine too. Maybe validate with the rest of the gang?
If that's a no-go, right now there's no way to do it in CSS only (we need the :has pseudo-selector for that, and Firefox does not support it yet). I would then put a CSS class on the host element "hasResultAction" and a TODO to refactor when Firefox supports it).
|
@jelmedini I think it's preferable for the position attribute to be as consistent as possible. |
There was a problem hiding this comment.
@louis-bompart just checked, and actually the effect inside SFINT is like this, we have a color change on hover. I also validated with the UX this change. so we are good to keep the background color hover in general :)
👍 feel free to merge this PR into yours :) |
* feat(atomic): add result action bar on hover * feat(atomic): change action bar css * feat(atomic): change result background color * feat(atomic): change action bar marging * feat(atomic): change to tailwind classes and small refacto * feat(atomic): update css to not change parent element css * feat(atomic): change prop name and update typo * feat(atomic): add css color variable * feat(atomic): remove important from css * feat(atomic): add extra padding for first element * embrace CSS (#3019) * use CSS for hover * handle first with CSS * always relative --------- Co-authored-by: Louis Bompart <[email protected]>
No description provided.