Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove abab #3908

Merged
merged 5 commits into from
Sep 5, 2024
Merged

chore!: remove abab #3908

merged 5 commits into from
Sep 5, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented May 7, 2024

@louis-bompart louis-bompart requested a review from a team as a code owner May 7, 2024 19:54
Copy link

github-actions bot commented May 7, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 202.6 201.1 -0.7
commerce 267.6 266.1 -0.6
search 364.8 363.3 -0.4
insight 345.5 344 -0.4
product-listing 257.9 256.4 -0.6
product-recommendation 171.6 170.2 -0.9
recommendation 215.5 214 -0.7
ssr 357.7 356.1 -0.4

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support

Copy link
Member

@olamothe olamothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be "pedantic", I guess this should go in v3.

Since that's when we will pin node to whatever the latest major is at that point in time.

But, I think the changes of it breaking clients implementation is relatively low...

@louis-bompart louis-bompart added this pull request to the merge queue May 8, 2024
@louis-bompart louis-bompart removed this pull request from the merge queue due to a manual request May 8, 2024
@louis-bompart
Copy link
Collaborator Author

To be "pedantic", I guess this should go in v3.

Since that's when we will pin node to whatever the latest major is at that point in time.

But, I think the changes of it breaking clients implementation is relatively low...

Technically true, yeah. Will put it on draft/hold.

@louis-bompart louis-bompart marked this pull request as draft May 8, 2024 15:56
@louis-bompart louis-bompart deleted the remove-abab branch August 26, 2024 16:34
@fbeaudoincoveo fbeaudoincoveo restored the remove-abab branch August 27, 2024 14:46
@fbeaudoincoveo fbeaudoincoveo marked this pull request as ready for review August 27, 2024 14:55
Copy link

github-actions bot commented Aug 28, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.3 242.8 -0.6
commerce 344.3 342.8 -0.4
search 418 416.5 -0.4
insight 398.3 396.8 -0.4
product-listing 308.6 307.1 -0.5
product-recommendation 215.2 213.7 -0.7
recommendation 258.1 256.6 -0.6
ssr 407.9 406.4 -0.4
ssr-commerce 356 354.5 -0.4

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart louis-bompart added this to the V3 milestone Aug 28, 2024
@louis-bompart louis-bompart changed the title chore: remove abab chore!: remove abab Aug 28, 2024
@louis-bompart louis-bompart added this pull request to the merge queue Sep 5, 2024
Merged via the queue into master with commit e7b5682 Sep 5, 2024
117 checks passed
@louis-bompart louis-bompart deleted the remove-abab branch September 5, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: dependency abab has been deprecated from npm
4 participants