Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commerce): only expose breadcrumbs with values #4132

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

Spuffynism
Copy link
Contributor

@Spuffynism Spuffynism commented Jun 28, 2024

By only exposing breadcrumbs with values, breadcrumbs without facet values will not be included. Since we also filter out breadcrumbs without values, the hasBreadcrumbs check will be false instead of true when there are facets with no values, which is the desired state.

CAPI-1089

@Spuffynism Spuffynism requested a review from a team as a code owner June 28, 2024 14:09
@Spuffynism Spuffynism requested a review from samisayegh June 28, 2024 14:09
@developer-experience-bot
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 204.9 204.9 0
commerce 293.3 293.4 0
search 372.9 372.9 0
insight 352.9 352.9 0
product-listing 267.3 267.3 0
product-recommendation 170.8 170.8 0
recommendation 217.8 217.8 0
ssr 365.7 365.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Contributor

@samisayegh samisayegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✅

@Spuffynism Spuffynism enabled auto-merge July 2, 2024 19:54
@Spuffynism Spuffynism added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit d3d57e8 Jul 3, 2024
91 of 92 checks passed
@Spuffynism Spuffynism deleted the fix-capi-1089-has-breadcrumbs branch July 3, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants