Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ep): remove rga non-schematized search cause #4208

Closed
wants to merge 7 commits into from

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart requested a review from a team as a code owner July 19, 2024 10:59
@louis-bompart louis-bompart requested review from olamothe, fpbrault and alexprudhomme and removed request for a team July 19, 2024 10:59
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.9 244.9 0
commerce 341.1 341.1 0
search 413.4 413.4 0
insight 392.1 391.9 0
product-listing 306.9 306.9 0
product-recommendation 211.2 211.2 0
recommendation 258 258 0
ssr 404.7 404.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens whenever a 'next' event is not specified ?

@louis-bompart
Copy link
Collaborator Author

What happens whenever a 'next' event is not specified ?

Good question: no actionCause will be sent.
This is the conclusion we reached with the DataPlatform team

@louis-bompart louis-bompart requested review from a team, erocheleau, SimonMilord and mmitiche and removed request for a team July 23, 2024 10:18
Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines -411 to -414
export const rephraseGeneratedAnswer = (): SearchAction => ({
actionCause: SearchPageEvents.rephraseGeneratedAnswer,
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not want to remove the retry as well here?

@louis-bompart
Copy link
Collaborator Author

Following the slack discussion, @mmitiche @SimonMilord , I rerequest your review.
I think this PR is ready to be scrubbed maybe 🤔

Base automatically changed from fix/KIT-3403 to master July 26, 2024 12:48
@github-actions github-actions bot requested a review from a team as a code owner July 26, 2024 12:48
@mmitiche
Copy link
Contributor

@louis-bompart Following the same slack discussion: https://coveo.slack.com/archives/C02ET4TQDD4/p1721921559026459?thread_ts=1721918413.953499&cid=C02ET4TQDD4, ServiceData/DataPlatform gang agreed to add the retryGeneratedAnswer and rephraseGeneratedAnswer to the schemas.

In that case wouldn't better to avoid removing these two causes now just to re-add them in like one week when they will be added to the accepted schemas?

@louis-bompart
Copy link
Collaborator Author

@louis-bompart Following the same slack discussion: https://coveo.slack.com/archives/C02ET4TQDD4/p1721921559026459?thread_ts=1721918413.953499&cid=C02ET4TQDD4, ServiceData/DataPlatform gang agreed to add the retryGeneratedAnswer and rephraseGeneratedAnswer to the schemas.

In that case wouldn't better to avoid removing these two causes now just to re-add them in like one week when they will be added to the accepted schemas?

yes.
Pending update, will reloop on the PR after the changes in the schema.

@louis-bompart
Copy link
Collaborator Author

Trying to dust off this PR @mmitiche, so essentially I should revert the changes that touches RGA, right?

@mmitiche
Copy link
Contributor

Trying to dust off this PR @mmitiche, so essentially I should revert the changes that touches RGA, right?

Exactly yeah @louis-bompart , the RGA related search causes have been added to the schemas 👍

@louis-bompart
Copy link
Collaborator Author

Third read, pretty certain everything has been standardized.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants