-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ep): remove rga non-schematized search cause #4208
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens whenever a 'next' event is not specified ?
Good question: no actionCause will be sent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
export const rephraseGeneratedAnswer = (): SearchAction => ({ | ||
actionCause: SearchPageEvents.rephraseGeneratedAnswer, | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we not want to remove the retry as well here?
Following the slack discussion, @mmitiche @SimonMilord , I rerequest your review. |
@louis-bompart Following the same slack discussion: https://coveo.slack.com/archives/C02ET4TQDD4/p1721921559026459?thread_ts=1721918413.953499&cid=C02ET4TQDD4, ServiceData/DataPlatform gang agreed to add the In that case wouldn't better to avoid removing these two causes now just to re-add them in like one week when they will be added to the accepted schemas? |
yes. |
Trying to dust off this PR @mmitiche, so essentially I should revert the changes that touches RGA, right? |
Exactly yeah @louis-bompart , the RGA related search causes have been added to the schemas 👍 |
Third read, pretty certain everything has been standardized. |
https://coveord.atlassian.net/browse/KIT-3404