Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(headless commerce ssr): merge controller props and ControllerDefinitionOption #4316

Merged
merged 117 commits into from
Sep 6, 2024

Conversation

y-lakhdar
Copy link
Contributor

Proposition

having all options in a single argument
image

just to stay consistent with all controllers (one argument per define function)

https://coveord.atlassian.net/browse/KIT-3486

y-lakhdar added 30 commits July 15, 2024 14:46
Copy link

github-actions bot commented Aug 24, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.3 244.3 0
commerce 344.3 344.3 0
search 418.1 418.1 0
insight 398.3 398.3 0
product-listing 308.6 308.6 0
product-recommendation 215.2 215.2 0
recommendation 258.1 258.1 0
ssr 408 408 0
ssr-commerce 356.1 356.1 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Base automatically changed from KIT-3397 to master August 27, 2024 16:57
@y-lakhdar y-lakhdar requested a review from a team as a code owner August 27, 2024 16:57
@y-lakhdar y-lakhdar enabled auto-merge August 30, 2024 18:19
@y-lakhdar y-lakhdar added this pull request to the merge queue Sep 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2024
@y-lakhdar y-lakhdar added this pull request to the merge queue Sep 6, 2024
Merged via the queue into master with commit 951b1c7 Sep 6, 2024
117 checks passed
@y-lakhdar y-lakhdar deleted the KIT-3486 branch September 6, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants