Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quantic)!: logic to handle opening smart snippet source inside salesforce added #4323

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

mmitiche
Copy link
Contributor

@mmitiche mmitiche commented Aug 27, 2024

SFINT-5438

  • Added logic to support opening smart sources in Salesforce with the help of the Navigation mixins utilities.
  • This changes contain a breaking change so this will be part of the v3 milestone.
  • The breaking changes consists of deleting two public properties title and url that were exposed in the QuanticSmartSnippetSource component and replacing them by the a new source property
  • Unit tests added.

Demo:

Screen.Recording.2024-08-27.at.3.45.55.PM.mov

@mmitiche mmitiche added this to the V3 milestone Aug 27, 2024
Copy link

github-actions bot commented Aug 27, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.3 244.3 0
commerce 344.3 344.3 0
search 418 418 0
insight 398.3 398.3 0
product-listing 308.6 308.6 0
product-recommendation 215.2 215.2 0
recommendation 258.1 258.1 0
ssr 407.9 407.9 0
ssr-commerce 356 356 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@mmitiche mmitiche marked this pull request as ready for review August 27, 2024 20:05
@mmitiche mmitiche requested a review from a team as a code owner August 27, 2024 20:05
@louis-bompart louis-bompart changed the title feat(quantic): logic to handle opening smart snippet source inside salesforce added feat(quantic)!: logic to handle opening smart snippet source inside salesforce added Aug 27, 2024
Copy link
Contributor

@SimonMilord SimonMilord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just to double check the tab in Salesforce isnt reloaded right when navigating within salesforce?

I am raising this because @Douminator2 raised this issue in the JIRA:

One important issue is that if the agent is on a voice call in Salesforce and the tab is reloaded, the voice app is disconnected. The support agent would not be able to use the Smart Snippet in the HIP which is/could be a blocker for some customer.

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have a clearer type for the source parameter

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mmitiche mmitiche added this pull request to the merge queue Sep 5, 2024
Merged via the queue into master with commit 7dca4f5 Sep 5, 2024
117 checks passed
@mmitiche mmitiche deleted the SFINT-5438 branch September 5, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants