-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quantic)!: logic to handle opening smart snippet source inside salesforce added #4323
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
...e-app/main/default/lwc/quanticSmartSnippetSource/__tests__/quanticSmartSnippetSource.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just to double check the tab in Salesforce isnt reloaded right when navigating within salesforce?
I am raising this because @Douminator2 raised this issue in the JIRA:
One important issue is that if the agent is on a voice call in Salesforce and the tab is reloaded, the voice app is disconnected. The support agent would not be able to use the Smart Snippet in the HIP which is/could be a blocker for some customer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have a clearer type for the source
parameter
...e-app/main/default/lwc/quanticSmartSnippetSource/__tests__/quanticSmartSnippetSource.test.js
Outdated
Show resolved
Hide resolved
...es/quantic/force-app/main/default/lwc/quanticSmartSnippetSource/quanticSmartSnippetSource.js
Show resolved
Hide resolved
...es/quantic/force-app/main/default/lwc/quanticSmartSnippetSource/quanticSmartSnippetSource.js
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSmartSnippet/quanticSmartSnippet.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
SFINT-5438
title
andurl
that were exposed in theQuanticSmartSnippetSource
component and replacing them by the a newsource
propertyDemo:
Screen.Recording.2024-08-27.at.3.45.55.PM.mov