Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(atomic)!: make textarea search box the default and only behavior #4332

Merged
merged 22 commits into from
Sep 6, 2024
Merged

feat(atomic)!: make textarea search box the default and only behavior #4332

merged 22 commits into from
Sep 6, 2024

Conversation

fbeaudoincoveo
Copy link
Contributor

@fbeaudoincoveo fbeaudoincoveo requested review from a team as code owners August 27, 2024 15:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 242.3 242.3 0
commerce 342.3 342.3 0
search 413.3 413.3 0
insight 396.3 396.3 0
product-listing 306.6 306.6 0
product-recommendation 213.2 213.2 0
recommendation 256.1 256.1 0
ssr 405.9 405.9 0
ssr-commerce 354.5 354.5 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@fbeaudoincoveo fbeaudoincoveo changed the title feat(atomic): Make textarea search box the default and only behavior feat(atomic): make textarea search box the default and only behavior Aug 27, 2024
@fbeaudoincoveo fbeaudoincoveo requested a review from a team as a code owner August 28, 2024 12:33
@fbeaudoincoveo fbeaudoincoveo changed the title feat(atomic): make textarea search box the default and only behavior feat!(atomic): make textarea search box the default and only behavior Aug 28, 2024
@fbeaudoincoveo fbeaudoincoveo changed the title feat!(atomic): make textarea search box the default and only behavior feat(atomic)!: make textarea search box the default and only behavior Aug 28, 2024
@louis-bompart louis-bompart added this to the V3 milestone Aug 28, 2024
dmgauthier
dmgauthier approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@dmgauthier dmgauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straitforward enough. LGTM

@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Sep 6, 2024
Merged via the queue into master with commit 5890858 Sep 6, 2024
112 checks passed
@fbeaudoincoveo fbeaudoincoveo deleted the KIT-2689 branch September 6, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@dmgauthier dmgauthier dmgauthier approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@olamothe olamothe olamothe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V3 RC
Development

Successfully merging this pull request may close these issues.
5 participants
@fbeaudoincoveo @olamothe @louis-bompart @dmgauthier @alexprudhomme