-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(headless)!: remove headless fetch & crypto polyfills #4358
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
@coveo/salesforce-integration can you help @alexprudhomme check/ensure that the IIFE bundle for Quantic are still kosher? |
I think it should be fine since I did not touch the quanticUmd build phase in headless/dist/quantic https://github.com/coveo/ui-kit/blob/KIT-3023/packages/headless/esbuild.mjs#L140-L163 |
I will do a quick sanity check/test from this PR to double check the Headless quantic bundle is still working property inside Salesforce. |
Yea we need to check with multiple configuration after this has changed:
@mmitiche if you have the time, please put ✅ if you have tested some of these, I can try to test the others :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure this isn't merged before it has been properly tested
Quantic working properly with:
|
https://coveord.atlassian.net/browse/KIT-3023 --------- Co-authored-by: Alex Prudhomme <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for making the tests!
I also confirmed that none of the Crypto stuff was needed due to any Locker/LWS limitation or distortion!
GG
https://coveord.atlassian.net/browse/KIT-3023
This PR is part of the making sure there are no 'require's in the headless ESM output.
Before
After
There is still this one that we will have to change or make it only available to the commonJs output. https://github.com/coveo/ui-kit/blob/KIT-3023/packages/headless/ponyfills/abortable-fetch-shim.js