Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(headless): typedoc plugin for coveo search box and theming #4361

Merged
merged 43 commits into from
Sep 9, 2024

Conversation

jpmarceau
Copy link
Contributor

@jpmarceau jpmarceau commented Aug 29, 2024

https://coveord.atlassian.net/browse/KIT-3421

This is the first of a number of PRs to generate Headless documentation using https://typedoc.org/
Here, I create a typedoc plugin to add an Atomic search box to the generated website, and theme it.

I suggest merging to a typedoc-release-branch rather than to master because the tags are in a messy state at the moment. I have enough to work on the plugin, but that's it. My next task will be to go through them to clean up and generate the typedoc website will all the content we want. Avoiding master will also help to avoid conflicts with the v3 release. Typedoc can wait until v3.

You can preview by:

  • checking out my branch
  • running npm install
  • running npm run build:typedoc from the headless package
  • opening packages/headless/docs/index.html

jpmarceau added 30 commits July 31, 2024 11:44
@jpmarceau jpmarceau marked this pull request as ready for review August 30, 2024 12:37
@jpmarceau jpmarceau requested a review from a team as a code owner August 30, 2024 12:37
@jpmarceau jpmarceau requested review from fpbrault, y-lakhdar, alexprudhomme, fbeaudoincoveo, spiracha-coveo and npushkarskii and removed request for a team August 30, 2024 12:37
@jpmarceau jpmarceau changed the title KIT-3421 typedoc plugin for coveo search box and theming docs(headless) typedoc plugin for coveo search box and theming Sep 4, 2024
@jpmarceau jpmarceau changed the title docs(headless) typedoc plugin for coveo search box and theming docs(headless): typedoc plugin for coveo search box and theming Sep 4, 2024
Copy link
Contributor

@fbeaudoincoveo fbeaudoincoveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

packages/headless/typedoc/lib/insertCoveoLogo.ts Outdated Show resolved Hide resolved
packages/headless/typedoc/assets/docs-style.css Outdated Show resolved Hide resolved
Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@jpmarceau
Copy link
Contributor Author

I'll merge this for now because the new sprint starts today, but if you have you have comments I can handle them in my next PR 👍

@jpmarceau jpmarceau merged commit 2e8ed4d into typedoc-release-branch Sep 9, 2024
67 of 113 checks passed
@jpmarceau jpmarceau deleted the KIT-3421-minimal-typedoc-website branch September 9, 2024 14:56
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2024
[KIT-3422](https://coveord.atlassian.net/browse/KIT-3422)

Follows #4361, which prepared the
code to build a typedoc website. I couldn't merge it because the
incomplete tagging state was causing build problems. I carry over the
code changes from that PR in this one here, but they've already been
reviewed. We should be able to merge them with this PR here.

Now, the main goal of this PR is adding lots of tags to organize the
contents of the Typedoc website. That's why there are lots of file
changes; they're very simple and repetitive.
(I also added missing documentation here and there, as I stumbled upon
it)

Rather than looking through all files, I recommend looking through the
built site and letting me know what you think. Before I keep
adding/tweaking things, now would be a good time for feedback 🙂

To look through the built site, either:

1: unzip the following and open `index.html`:
[docs.zip](https://github.com/user-attachments/files/17497151/docs.zip)


or

2: 
    - check out my branch
    - run `npm install`
    - run `npm run build:typedoc` from the headless package
    - open `packages/headless/docs/index.html`

[KIT-3422]:
https://coveord.atlassian.net/browse/KIT-3422?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Alex Prudhomme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants