Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(headless)!: add export field in package.json #4392

Merged
merged 18 commits into from
Sep 17, 2024
Merged

chore(headless)!: add export field in package.json #4392

merged 18 commits into from
Sep 17, 2024

Conversation

alexprudhomme
Copy link
Contributor

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 241.4 241.4 0
commerce 339.5 339.5 0
search 409.8 409.8 0
insight 394.6 394.6 0
recommendation 252.5 252.5 0
ssr 403.5 403.5 0
ssr-commerce 351.7 351.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme changed the title export field in headless chore(headless)!: add export field in package.json Sep 11, 2024
@alexprudhomme alexprudhomme marked this pull request as ready for review September 11, 2024 14:04
@alexprudhomme alexprudhomme requested review from a team as code owners September 11, 2024 14:04
louis-bompart
louis-bompart approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@louis-bompart louis-bompart added this to the V3 milestone Sep 16, 2024
fbeaudoincoveo
fbeaudoincoveo approved these changes Sep 16, 2024
View reviewed changes
packages/headless/package.json Outdated Show resolved Hide resolved
@alexprudhomme alexprudhomme merged commit a834c2f into master Sep 17, 2024
117 checks passed
@alexprudhomme alexprudhomme deleted the KIT-2541-1 branch September 17, 2024 14:53
fpbrault pushed a commit that referenced this pull request Sep 17, 2024
@alexprudhomme @fpbrault
chore(headless)!: add export field in package.json (#4392)
fa579dc 
https://coveord.atlassian.net/browse/KIT-2541
fpbrault pushed a commit that referenced this pull request Sep 17, 2024
@alexprudhomme @fpbrault
chore(headless)!: add export field in package.json (#4392)
c8d28db 
https://coveord.atlassian.net/browse/KIT-2541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

Assignees

@louis-bompart louis-bompart

Labels
None yet
Projects
None yet
Milestone
V3 RC
Development

Successfully merging this pull request may close these issues.
3 participants
@alexprudhomme @louis-bompart @fbeaudoincoveo