Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(headless): ensure each result keep a reference of its 'source' searchId V2 #4510

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

y-lakhdar
Copy link
Contributor

Make sure to keep the id of the search that returned each result.

https://coveord.atlassian.net/browse/KIT-3481

backporting #4391

Copy link

github-actions bot commented Oct 9, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.5 244.5 0
commerce 343 343.1 0
search 416.9 417.2 0.1
insight 394.9 395 0
product-listing 306.7 306.8 0
product-recommendation 215.3 215.3 0
recommendation 257.7 257.7 0
ssr 407.4 407.7 0.1
ssr-commerce 353.6 353.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@y-lakhdar y-lakhdar added this pull request to the merge queue Oct 11, 2024
Merged via the queue into v2 with commit 269b205 Oct 11, 2024
115 checks passed
@y-lakhdar y-lakhdar deleted the KIT-3481-v2 branch October 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants