Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic): fix clicks for recommendation lists in grid display mode #4634

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

dguerinCoveo
Copy link
Contributor

@dguerinCoveo dguerinCoveo commented Nov 5, 2024

Backports #4623 into the V2 branch.
CDX-1598

Copy link

github-actions bot commented Nov 5, 2024

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.5 244.5 0
commerce 343.1 343.1 0
search 417.2 417.2 0
insight 395 395 0
product-listing 306.8 306.8 0
product-recommendation 215.3 215.3 0
recommendation 257.7 257.7 0
ssr 407.7 407.7 0
ssr-commerce 353.7 353.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@dguerinCoveo dguerinCoveo changed the title Cdx 1598 v2 fix(atomic): fix clicks for recommendation lists in grid display mode Nov 5, 2024
@dguerinCoveo dguerinCoveo added this pull request to the merge queue Nov 6, 2024
Merged via the queue into v2 with commit b65b5c7 Nov 6, 2024
110 checks passed
@dguerinCoveo dguerinCoveo deleted the CDX-1598-v2 branch November 6, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants