fix(quantic): CRGA component not showing collapsed when answer appears without streaming #4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
github-actions
bot
requested review from
olamothe,
fpbrault,
louis-bompart and
fbeaudoincoveo
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Just a question of renaming the event so it better describes what it is.
And don't forget to move the two lines of comments that go with the code.
This is a very good example why the code should be "self-explanatory" in this case I chose to add those comments, may not have been the best idea, because now we need to remember to move those comments along with the code. FYI
...ic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js
Outdated
Show resolved
Hide resolved
...ges/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js
Outdated
Show resolved
Hide resolved
SimonMilord
force-pushed
the
SFINT-5914
branch
from
7187613 to
326ed68
Compare
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Jan 20, 2025
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
…tedAnswer component (#4871) [SFINT-5855](https://coveord.atlassian.net/browse/SFINT-5855) ## IN THIS PR: - Added new property to the `quanticGeneratedAnswer` component called `maxCollapsedHeight` (same name as in Atomic). This property dictates what is the desired height of the generated answer before we collapse it. - Default value is still 250px - We now also have an accepted range from 150px to 500px, otherwise the default value is applied. Note: We want to merge this [PR](#4840) first since there will be conflicts. ## DEMO: #### Example when `maxCollapsedHeight` is within the acceptable range (here 151px is within 150 and 500px) <img width="760" alt="image" src="https://github.com/user-attachments/assets/6f281318-c9c9-4f64-87e0-4cc28bbef36e" /> OUTCOME: it caps the height to 151px since 151px is between 150 and 500px. #### Example when `maxCollapsedHeight` is outside the acceptable range (here 100px is NOT within 150 and 500px) <img width="1482" alt="image" src="https://github.com/user-attachments/assets/c3aaa141-995d-4254-979a-7356ad64c83d" /> OUTCOME: it displays the entire answer since the stated `maxCollapsedHeight` of 100px is NOT within 150 and 500px. Therefore, the answer height of 156px being smaller than 250px (Default height) is fully displayed. It also logs a warning in the console about this value of maxCollapsedHeight being outside the acceptable range. #### Example when `maxCollapsedHeight` is outside the acceptable range (here 600px is NOT within 150 and 500px) <img width="1596" alt="image" src="https://github.com/user-attachments/assets/83e62fd4-b395-4aab-be9f-25a71efd93a3" /> OUTCOME: it displays the entire answer since the stated `maxCollapsedHeight` of 600px is NOT within 150 and 500px. Therefore, the answer height of 195px being smaller than 250px (Default height) is fully displayed. It also logs a warning in the console about this value of maxCollapsedHeight being outside the acceptable range. ## UNIT TESTS: <img width="1024" alt="image" src="https://github.com/user-attachments/assets/e8c0a748-f0a2-44e2-bbf5-8a560ceec63a" /> [SFINT-5855]: https://coveord.atlassian.net/browse/SFINT-5855?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFINT-5914
ISSUE:
This is following a maintenance case where some cases of customers would trigger a CRGA answer directly without the stream. This would cause the answer to show fully rather than collapsed.
The culprit is caused by the following code:
The
generatedAnswerElementHeight, whenisStreamingis false ( case where the answer is generated in one shot rather than being streamed), is essentially 0. Therefore, thethis._exceedsMaximumHeight = 0 > 250pxwhich is false and therefore does not result in the answer being collapsed. This is happening since the component does not re-render and therefore does not re-calculates the height and CSS variables.SOLUTION:
Adding
quantic__answergeneratedevent.We are proposing dispatching an event from the
quanticGeneratedAnswerContentcomponent when the answer's HTML is updated. We then listen for this event in thequanticGeneratedAnswercomponent and recalculate the CSS variables.When the event is triggered, it calls this function:
E2E: