-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(insight): some ui fixes for insight panel #4845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
mikegron
requested review from
olamothe,
fpbrault,
y-lakhdar and
louis-bompart
January 13, 2025 16:14
louis-bompart
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, would advise to add mo' tests
louis-bompart
temporarily deployed
to
PR Artifacts
January 13, 2025 17:19 — with
GitHub Actions
Inactive
@jelmedini that might affect this https://coveord.atlassian.net/browse/SVCC-3579 ! |
dguerinCoveo
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains multiple small fixes for the insight panel!
SVCC-4282 Insight Facets cannot be collapsed
Missing
if (collapsed)
in the render method to not render the body if collapsedBefore
After
SVCC-4284 Display As Link in Insight Facets could select multiple values
Change
toggleSelect
totoggleSingleSelect
if the displayAs is set tolink
(like normal facets).Before
SFINT-5866 Spacing after searchbox if no tabs and filters
The searchbox had zero
height
, so the padding was not applied correctly to the search section. When the facets or user actions button was added, the height was set correctly so I added the sameheight: 2.6rem
to the searchbox.Before
After
SVCC-4348 Result padding should be controlled with a variable
In the insight result CSS, changed
@apply p-6;
to use--atomic-layout-spacing-x
so we can control the padding externally.