Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insight): some ui fixes for insight panel #4845

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

mikegron
Copy link
Contributor

@mikegron mikegron commented Jan 10, 2025

This PR contains multiple small fixes for the insight panel!

SVCC-4282 Insight Facets cannot be collapsed

Missing if (collapsed) in the render method to not render the body if collapsed

Before

facet collapsed

After

facet collapsed 2


SVCC-4284 Display As Link in Insight Facets could select multiple values

Change toggleSelect to toggleSingleSelect if the displayAs is set to link (like normal facets).

Before

afgfgfds


SFINT-5866 Spacing after searchbox if no tabs and filters

The searchbox had zero height, so the padding was not applied correctly to the search section. When the facets or user actions button was added, the height was set correctly so I added the same height: 2.6rem to the searchbox.

Before

image

After

image


SVCC-4348 Result padding should be controlled with a variable

In the insight result CSS, changed @apply p-6; to use --atomic-layout-spacing-x so we can control the padding externally.

image

@mikegron mikegron self-assigned this Jan 10, 2025
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243 243 0
commerce 354.1 354.1 0
search 414 414 0
insight 405.3 405.3 0
recommendation 255.2 255.2 0
ssr 407.5 407.5 0
ssr-commerce 371.4 371.4 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@mikegron mikegron marked this pull request as ready for review January 13, 2025 16:14
@mikegron mikegron requested review from a team as code owners January 13, 2025 16:14
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, would advise to add mo' tests

@mikegron
Copy link
Contributor Author

@jelmedini that might affect this https://coveord.atlassian.net/browse/SVCC-3579 !

@mikegron mikegron added this pull request to the merge queue Jan 14, 2025
auto-merge was automatically disabled January 14, 2025 16:01

Pull Request is not mergeable

Merged via the queue into master with commit 03db330 Jan 14, 2025
95 checks passed
@mikegron mikegron deleted the fix/SFINT-5866-insight-small-bugs branch January 14, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants