feat(atomic): add button function for lit components #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-lakhdar
requested review from
mikegron,
dguerinCoveo,
olamothe,
fpbrault,
fbeaudoincoveo and
alexprudhomme
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
y-lakhdar
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
y-lakhdar
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Comment on lines
+4
to
+27
| interface LoadMoreButtonProps { | ||
| i18n: i18n; | ||
| onClick: () => void; | ||
| moreAvailable: boolean; | ||
| label?: 'load-more-results' | 'load-more-products'; | ||
| } | ||
|
|
||
| export function loadMoreButton({ | ||
| i18n, | ||
| onClick, | ||
| moreAvailable, | ||
| label, | ||
| }: LoadMoreButtonProps) { | ||
| if (!moreAvailable) { | ||
| return; | ||
| } | ||
| const props: ButtonProps = { | ||
| style: 'primary', | ||
| part: 'load-more-results-button', | ||
| class: 'my-2 p-3 font-bold', | ||
| onClick: () => onClick(), | ||
| }; | ||
| return button({props, children: i18n.t(label || 'load-more-results')}); | ||
| } |
There was a problem hiding this comment.
Can you rename this to 'button.ts' and rename the stencil one to 'stencil-button' like the normal button ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Lit equivalent to
<Button>functional element.Also replaced
button.tsxtostencil-button.tsxwhich is responsible for all the file changesUsage
With Stencil
With Lit
Question
Lit does not natively support spreading attributes as we do in .tsx files, which can lead to code repetition. To address this, we could use lit-helpers to avoid duplicating attributes, properties, and events while maintaining consistency in our patterns.
WDYT