chore: relocate dist/components to dist/atomic/components #4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
olamothe,
fpbrault,
y-lakhdar and
fbeaudoincoveo
alexprudhomme
approved these changes
Jan 15, 2025
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
louis-bompart
force-pushed
the
KIT-3858
branch
from
846c143 to
aacac54
Compare
louis-bompart
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
louis-bompart
force-pushed
the
KIT-3858
branch
from
aacac54 to
e01c13b
Compare
louis-bompart
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
louis-bompart
force-pushed
the
KIT-3858
branch
from
e01c13b to
1c7728d
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
force-pushed
the
KIT-3858
branch
from
1c7728d to
e2ff42e
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Lit adaptation layer, we need the components directory in the CDN files.
However, we only deploy dist/atomic to the CDN with the current structure. Changing what we deploy to the CDN is the riskiest change because even if we support only a given # of entry points, there is no protection.
NPM and exports have this level of protection, so instead, I used the "CDN" file structure as the immutable and changed things for NPM.
https://coveord.atlassian.net/browse/KIT-3858