chore: add tailwind styles support for lit components #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
This reverts commit 55c98cb.
fpbrault
force-pushed
the
chore/lit-twstyles
branch
from
902bcef to
63657d1
Compare
fpbrault
requested review from
olamothe,
y-lakhdar,
louis-bompart and
alexprudhomme
fpbrault
changed the title
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
approved these changes
Jan 17, 2025
y-lakhdar
previously requested changes
Jan 21, 2025
the process-css.mjs file was not adding files to the appropriate path in the dist folder. I updated the logic so that the distDir variable can be computed based on the tsconfig file... not hard coded
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the TailwindLitElement class which can be used to use tailwind classes in multiple Lit components with no unnecessary CSS duplication.
At this time this is for Tailwind V3 but this can be made compatible with Tailwind V4 with minimal changes.
Based on #4804, without the atomic-text component and its styles. You can refer to the comments for details on usage.
https://coveord.atlassian.net/browse/KIT-3911