Fix switch pattern #1006
Merged
Fix switch pattern #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
added
the
tenet-coverage
|
Yes that's a good solution. Thanks again to @jakubch1 for the hint. The only thing that doesn't really fit is the hits count, line 36 is actually only hit once.
But it's certainly more lightweight than what I did. I mixed this skip and the other algorithm and therefore had to do some changes in the instrumenter ..., definitely more heavy. |
|
@daveMueller with the idea of "skip nested lines" fixes accounting issue |
MarcoRossignoli
requested review from
tonerdo and
petli
and removed request for
tonerdo
|
@daveMueller please feel free to review this. |
|
@MarcoRossignoli Sure I will just need approx. 2 days to find some spare time. I'm really interested in the key differences to my implementation and why I couldn't make I run without touching the |
jakubch1
reviewed
Dec 7, 2020
daveMueller
reviewed
Dec 9, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
0xced
added a commit
to serilog-contrib/serilog-formatting-log4net
that referenced
this pull request
Jan 20, 2021
Keeping 100% coverage now that [switch expressions coverage][1] has been fixed in coverlet. [1]: coverlet-coverage/coverlet#1006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #936
cc: @daveMueller I did some test and skipping branches and breakpoint expression seems to work