Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly build versioning #806

Merged
merged 2 commits into from
Apr 11, 2020

Conversation

MarcoRossignoli
Copy link
Collaborator

@clairernovotny I fixed nightly version.

@MarcoRossignoli
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MarcoRossignoli
Copy link
Collaborator Author

Need to fix integration test to find new version name.

@MarcoRossignoli MarcoRossignoli changed the title Fix nightly build versioning [WIP]Fix nightly build versioning Apr 9, 2020
@clairernovotny
Copy link
Contributor

@MarcoRossignoli you can see how Rx does integration tests here. We use a multi-stage build where artifacts are published in build and then downloaded on multiple platforms:
https://github.com/dotnet/reactive/blob/master/azure-pipelines.rx.yml

I download the artifacts into a directory and then add/update via the dotnet command:
https://github.com/dotnet/reactive/blob/master/azure-pipelines.rx.yml#L169-L175

In all cases NBGV knows what the version is.

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented Apr 9, 2020

@MarcoRossignoli MarcoRossignoli changed the title [WIP]Fix nightly build versioning Fix nightly build versioning Apr 11, 2020
@MarcoRossignoli
Copy link
Collaborator Author

Issue related to long path dotnet/sdk#11244

@MarcoRossignoli MarcoRossignoli merged commit fa138c0 into coverlet-coverage:master Apr 11, 2020
@MarcoRossignoli MarcoRossignoli deleted the fixnightly branch April 11, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants