feat: Add PerformanceApi to SearchEngine #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
requested review from
JF-Cozy,
Merkur39,
zatteo and
doubleface
as code owners
Base automatically changed from
fix/searchengine_realtime_register_twice
to
master
January 29, 2025 17:32
Ldoppea
force-pushed
the
feat/performances
branch
2 times, most recently
from
1e13480 to
2727210
Compare
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Jan 29, 2025
In cozy/cozy-libs#2720 we added PerformanceAPI in the SearchEngine This commit reflect the changes to the SearchEngine constructor Related PR: cozy/cozy-libs#2720
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Jan 29, 2025
In cozy/cozy-libs#2720 we added PerformanceAPI in the SearchEngine This commit reflect the changes to the SearchEngine constructor Related PR: cozy/cozy-libs#2720
JF-Cozy
approved these changes
Jan 30, 2025
| this.client = client | ||
| this.searchIndexes = {} as SearchIndexes | ||
| this.performanceApi = performanceApi ?? defaultPerformanceApi |
There was a problem hiding this comment.
j'ai pas suivi pourquoi on importe 2 API et qu'on doit les charger toutes les 2 ? Est-ce que cozy-client ne devrait pas retourner un performanceOrDefaultApi par exemple qui porterait cette responsabilité ?
There was a problem hiding this comment.
Plus d'infos : https://github.com/cozy/cozy-client/blob/master/docs/performances.md
Est-ce que cozy-client ne devrait pas retourner un performanceOrDefaultApi
C'est le cas, cf L3. Mais tu peux vouloir une autre implem que celle par défaut, selon si tu es AA ou Web
There was a problem hiding this comment.
Ce n'est pas ça que j'avais pas compris, en fait j'ai mal lu on n'importe pas 2 API, le deuxième import est un type :) Et dans la condition la première vient des Props, et non de cozy-client
paultranvan
approved these changes
Jan 30, 2025
|
|
||
| this.performanceApi.measure({ | ||
| markName: markName, | ||
| category: 'Search' |
There was a problem hiding this comment.
The 'search' category might be a bit misleading here, since we are indexing documents. Furthermore, this category name is reused later for the actual search
There was a problem hiding this comment.
Would SearchEngine work better?
There was a problem hiding this comment.
Actually I didn't realized this category is used for the whole SeachEngine (indexing + search),so let's keep it like it
paultranvan
reviewed
Jan 30, 2025
Ldoppea
force-pushed
the
feat/performances
branch
from
2727210 to
2e87021
Compare
`cozy-client` has been upgraded to `53.1.0` in order to retrieve typings for the Performance API Related PR: cozy/cozy-client#1574
We want to add some metrics to understand where time is consumed All measurement are made through the PerformanceApi helper that can be injected from consuming app Related PR: cozy/cozy-client#1574
Ldoppea
force-pushed
the
feat/performances
branch
from
bc88f76 to
1a3f045
Compare
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 7, 2025
`cozy-dataproxy-lib` has been upgraded to `3.2.0` in order to retrieve the new Performance API implementation Related PR: cozy/cozy-libs#2720
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 7, 2025
In cozy/cozy-libs#2720 we added PerformanceAPI in the SearchEngine This commit reflect the changes to the SearchEngine constructor Related PR: cozy/cozy-libs#2720
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 7, 2025
`cozy-dataproxy-lib` has been upgraded to `3.2.0` in order to retrieve the new Performance API implementation Related PR: cozy/cozy-libs#2720
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 7, 2025
In cozy/cozy-libs#2720 we added PerformanceAPI in the SearchEngine This commit reflect the changes to the SearchEngine constructor Related PR: cozy/cozy-libs#2720
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 12, 2025
`cozy-dataproxy-lib` has been upgraded to `3.2.0` in order to retrieve the new Performance API implementation Related PR: cozy/cozy-libs#2720
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 12, 2025
In cozy/cozy-libs#2720 we added PerformanceAPI in the SearchEngine This commit reflect the changes to the SearchEngine constructor Related PR: cozy/cozy-libs#2720
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 12, 2025
`cozy-dataproxy-lib` has been upgraded to `3.2.0` in order to retrieve the new Performance API implementation Related PR: cozy/cozy-libs#2720
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 12, 2025
In cozy/cozy-libs#2720 we added PerformanceAPI in the SearchEngine This commit reflect the changes to the SearchEngine constructor Related PR: cozy/cozy-libs#2720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add some metrics to understand where time is consumed
All measurement are made through the PerformanceApi helper that can be injected from consuming app
Measurements have been added for the
indexDocuments()duration (global and per doctype) and thesearch()durationRelated PR: cozy/cozy-client#1574