-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ui #95
Merged
Merged
Feature/ui #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had a param to use tf frame surface instead of searching biggest plane for object segmentation
…ject) Change output directory location
…round truth point cloud to png conversion written but untested.
Add detected object list republisher
wow this is intense, has this branch just been going on for a very long time? |
Yes it needs to be merged
Best,
Chris
…Sent from my phone
________________________________
From: Andrew Hundt <[email protected]>
Sent: Thursday, September 21, 2017 11:11:16 PM
To: cpaxton/costar_stack
Cc: Chris Paxton; Author
Subject: Re: [cpaxton/costar_stack] Feature/ui (#95)
wow this is intense, has this branch just been going on for a very long time?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#95 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADImZ02cEVIKDlzNVTG_aWuD2SUDJtOmks5sk0-EgaJpZM4OxKVg>.
|
I looked through it and this seems pretty good overall to me. I don't think such a big and well tested PR is worth nitpicking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is