docs(notifications): update Install instructions in README.md #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description The installation instructions provided in the Install sections were incomplete. I tried for the first time to use this package and I was not able to make it works just following the provided instructions. Digging into the sources, I looked at the `example` folder and I noticed that there was a custom code in the `AndroidManifest.xml`. Just adding it to mine solved the issue and the plugin started to work.
|
Thanks - has been merged and released as version 2.0.1 |
|
I don’t think there was the need of a version update since it was just a docs update, anyway thanks for accepting the PR as it is |
hibitness-quan-nguyen2
pushed a commit
to hibitness/flutter-plugins
that referenced
this pull request
Dec 18, 2023
docs(notifications): update Install instructions in README.md
hibitness-quan-nguyen2
pushed a commit
to hibitness/flutter-plugins
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The installation instructions provided in the Install sections were incomplete.
I tried for the first time to use this package and I was not able to make it works just following the provided instructions.
Digging into the sources, I looked at the
examplefolder and I noticed that there was a custom code in theAndroidManifest.xml.Just adding it to mine solved the issue and the plugin started to work.