Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nlohmann_json to v3.11.1 #596

Merged

Conversation

falbrechtskirchinger
Copy link

  • I've followed this guide step by step carefully. [Yes]

Version v3.11.0 was omitted because of a bug that was quickly fixed in v3.11.1. Is there a way to mark such a version and generate an error in case a user requests it?

Copy link

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, easiest solution is the one you chose, just don't provide it through hunter and add a comment why it was omitted . This way one has to actively try to get the broken version. And this way the user has to handle the consequences himself

@NeroBurner NeroBurner merged commit ca922ef into cpp-pm:master Aug 2, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the pr.nlohmann_json_v3_11_1 branch August 2, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants