[TRIVIAL] Add missing includes #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* std::logic_error is defined in <stdexcept>. These files reference it without including that header. In most environments, the definition is included through other headers, but not all.
2 tasks
|
Ed, I've invited you as a maintainer of the repository if you would like to merge this when you feel it is ready to do so. Thanks! |
|
Fantastic! Thanks, Vinnie. I think it's ready to merge now if there are no objections. I'll push the button Friday morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::logic_erroris defined in<stdexcept>. These files changed in this PR reference it without including that header. In most environments, the definition is included through other headers, but not all. Specifically, I ran into a build error with rippled Windows non-unity builds after some headers were reordered.See also: XRPLF/rippled#5061