Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve compatibility with go <= 1.17 #130

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

thaJeztah
Copy link
Collaborator

@thaJeztah thaJeztah commented Dec 15, 2024

Revert "md2man.go: rename ioutil to io" for compat with go <= 1.17

This reverts commit 7607604.

md2man: use local copy of bytes.Copy for compat with go < 1.1

@thaJeztah
Copy link
Collaborator Author

OK; looks like 1.11 doesn't work;

Error: md2man/roff.go:107:28: undefined: bytes.Cut
Error: md2man/roff.go:140:18: undefined: strings.ReplaceAll

@thaJeztah thaJeztah changed the title Revert "md2man.go: rename ioutil to io" for compat with go <= 1.17 Preserve compatibility with go <= 1.17 Dec 15, 2024
@thaJeztah thaJeztah self-assigned this Dec 15, 2024
@cpuguy83
Copy link
Owner

Is this ready, @thaJeztah?

@thaJeztah
Copy link
Collaborator Author

@cpuguy83 if you can approve #131, then I'll rebase this one (CI is currently red due to golangci-lint incompatible with go1.23)

@thaJeztah thaJeztah marked this pull request as ready for review December 16, 2024 17:47
@cpuguy83 cpuguy83 merged commit ae728a9 into cpuguy83:master Dec 16, 2024
5 checks passed
@thaJeztah thaJeztah deleted the keep_go111_compat branch December 16, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants