Refresh and improve CI #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update Go versions used in tests to current stable releases (plus 1.13 which is still used by Moby). 2. Explicitly specify ubuntu version used. 3. Bump actions/setup-go to v2. Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
|
@thaJeztah @cpuguy83 PTAL |
The targets being removed were used by Travis CI, which is long gone. Golangci-lint is now run by GHA CI without any help from the Makefile. If a developer wants to run it locally, they probably have it installed already, and typing golangci-lint run ./... is relatively easy. Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add golangci-lint job (which used to be part of Travis-CI but was not moved over to GHA).
Update Go versions used in tests to current stable releases
(plus 1.13 which is still used by Moby).
Explicitly specify ubuntu version used.
Bump actions/setup-go to v2.