Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing lat-long to UTM conversion #620

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

ayrton04
Copy link
Collaborator

Addresses #619.

FYI @kosmastsk

@ayrton04
Copy link
Collaborator Author

@kosmastsk, would you be able/willing to test this?

@kosmastsk
Copy link

@ayrton04 I will test it soon and let you know if the issue is fixed.

@SteveMacenski
Copy link
Collaborator

@kosmastsk please submit for ROS2 as well

@ayrton04
Copy link
Collaborator Author

I'll take care of porting it once we've confirmed it works.

@kosmastsk
Copy link

@ayrton04 I just checked it with the same data that I used when I made the issue, and now it works fine! Thank you!
Do you want me to file an issue for nav2 as well?

Copy link
Collaborator

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues if you say it works! I'm not working with GPS right now to be able to independently verify but the code looks good (obviously...)

@ayrton04 ayrton04 merged commit a7da2f6 into melodic-devel Feb 3, 2021
@ayrton04 ayrton04 deleted the fix-ll-utm-conversion branch February 3, 2021 08:22
ayrton04 added a commit that referenced this pull request Feb 3, 2021
Thanks again for the report. I'll get this into `noetic-devel` and the relevant ROS2 branches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants