fix: override default iframe border so it's really hidden #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey David, thank you so much for helping with the library. Nice catch. I haven't seen this before. We just released a new version today, v1.0.3. This change will get published to npm with the next version 1.0.4 by next week. |
|
@dpramar A new version with this change has been published to npm, v1.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that iframes have a default border of 2px, so when printing it's adding a 4x4px at the bottom of the page that in pages using 100vh is an issue because it adds scroll.
iframes default styles:
After printing, at the bottom of the page:
After fix: