fix: remove produce syntax from spans stream to drastically improve p…

…erformance at 5k + entries / move number of logs to the left of the filter
crabnebula-dev · Feb 8, 2024 · 529361e · 529361e
1 parent 3eb0abc
commit 529361e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/clients/web/src/lib/connection/transport.tsx b/clients/web/src/lib/connection/transport.tsx
@@ -4,7 +4,7 @@ import { InstrumentClient } from "~/lib/proto/instrument.client";
 import { TauriClient } from "~/lib/proto/tauri.client";
 import { SourcesClient } from "~/lib/proto/sources.client.ts";
 import { MetadataClient } from "../proto/meta.client";
-import { SetStoreFunction, createStore, produce } from "solid-js/store";
+import { SetStoreFunction, createStore } from "solid-js/store";
 import {
   HealthCheckRequest,
   HealthCheckResponse_ServingStatus,
@@ -115,12 +115,9 @@ export function addStreamListneners(
 
     const spansUpdate = update.spansUpdate;
     if (spansUpdate && spansUpdate.spanEvents.length > 0) {
-      setMonitorData(
-        "spans",
-        produce((clonedSpans) =>
-          updatedSpans(clonedSpans, spansUpdate.spanEvents)
-        )
-      );
+      setMonitorData("spans", (spans) => [
+        ...updatedSpans(spans, spansUpdate.spanEvents),
+      ]);
     }
   });
 }
diff --git a/clients/web/src/views/dashboard/console.tsx b/clients/web/src/views/dashboard/console.tsx
@@ -60,6 +60,7 @@ export default function Console() {
   return (
     <>
       <Toolbar>
+        <div>({filteredLogs().length})</div>
         <input
           value={filter.textContent}
           onInput={(e) =>