fix: since solid is optimizing the reactivity the first version does …

…not work without the observed props being above the if (#329)
crabnebula-dev · Jul 2, 2024 · 5f84d1e · 5f84d1e
1 parent 177c0f6
commit 5f84d1e
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/clients/web/src/components/virtual-list.tsx b/clients/web/src/components/virtual-list.tsx
@@ -53,14 +53,16 @@ export function VirtualList<VirtualItem>(props: {
     virtualizer.scrollElement?.addEventListener("wheel", checkScrollDirection);
   });
 
-  createEffect(() => {
-    if (
-      autoScrollStarted ||
-      !props.shouldAutoScroll ||
-      !props.dataStream.length
-    )
-      return;
+  const initAutoScroll = (
+    shouldAutoScroll: boolean | undefined,
+    length: number,
+  ) => {
+    if (!shouldAutoScroll || !length || autoScrollStarted) return;
     requestAnimationFrame(autoScroll);
+  };
+
+  createEffect(() => {
+    initAutoScroll(props.shouldAutoScroll, props.dataStream.length);
   });
 
   return (